Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jwt plugin pushes cookie_names as nil instead empty table/slice #9

Closed
davidcv5 opened this issue Apr 7, 2019 · 0 comments
Closed

Jwt plugin pushes cookie_names as nil instead empty table/slice #9

davidcv5 opened this issue Apr 7, 2019 · 0 comments

Comments

@davidcv5
Copy link
Contributor

davidcv5 commented Apr 7, 2019

@hbagdi here is the issue we discussed on slack
Not sure if it could also affect other cases beside cookie_names, maybe there is some general solution. Thanks a lot!!
hbagdi added a commit that referenced this issue Apr 11, 2019
@hbagdi
fix(file) empty array should not be converted to nil
14d15e4 
While reading in the plugin configs, an explicit empty JSON array was
being converted to `nil`, which results in `null` in JSON, resulting in
a false-positive for a diff and sync.

Fix #9
@hbagdi hbagdi closed this as completed in 5e20d1c Apr 11, 2019
rainest pushed a commit that referenced this issue Apr 21, 2021
@hbagdi
feat(upstream) add Algorithm field to Upstream struct
6afaf06 
Kong 1.3 adds an `algorithm` field to the Upstream entity.

From #9
rainest pushed a commit that referenced this issue Apr 21, 2021
@hbagdi
fix(file) empty array should not be converted to nil
c2681ee 
While reading in the plugin configs, an explicit empty JSON array was
being converted to `nil`, which results in `null` in JSON, resulting in
a false-positive for a diff and sync.

Fix #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidcv5