feat: always export ID for CACertificate #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtls-auth credentials can be tied to CACertificate. This leads to a probelm where mtls-auth credential can contain an ID of a CACertificate but CACertificate is exported to state file without an ID. Now, on a subsequent `sync` from scratch, the ID of CACertificate will be auto generated. This breaks the link between mtls-auth credential and CACertificate, and the sync fails. With this patch, like Certificate entity, ID of CACertificate is always exported, no matter what.
rainest
pushed a commit
that referenced
this pull request
Apr 21, 2021
mtls-auth credentials can be tied to CACertificate. This leads to a probelm where mtls-auth credential can contain an ID of a CACertificate but CACertificate is exported to state file without an ID. Now, on a subsequent `sync` from scratch, the ID of CACertificate will be auto generated. This breaks the link between mtls-auth credential and CACertificate, and the sync fails. With this patch, like Certificate entity, ID of CACertificate is always exported, no matter what. From #193
AntoineJac
pushed a commit
that referenced
this pull request
Jan 23, 2024
mtls-auth credentials can be tied to CACertificate. This leads to a probelm where mtls-auth credential can contain an ID of a CACertificate but CACertificate is exported to state file without an ID. Now, on a subsequent `sync` from scratch, the ID of CACertificate will be auto generated. This breaks the link between mtls-auth credential and CACertificate, and the sync fails. With this patch, like Certificate entity, ID of CACertificate is always exported, no matter what. From #193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mtls-auth credentials can be tied to CACertificate.
This leads to a probelm where mtls-auth credential can contain an ID of
a CACertificate but CACertificate is exported to state file without an
ID. Now, on a subsequent
syncfrom scratch, the ID of CACertificatewill be auto generated. This breaks the link between mtls-auth
credential and CACertificate, and the sync fails.
With this patch, like Certificate entity, ID of CACertificate is always
exported, no matter what.