Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: diff/sync commands - read from stdin - resolves #8 #11

Closed
wants to merge 11 commits into from
Closed

Feature: diff/sync commands - read from stdin - resolves #8 #11

wants to merge 11 commits into from

Conversation

matthewbednarski
Copy link
Contributor

Feature: diff/sync commands - read from stdin - resolves #8

hbagdi
hbagdi reviewed Apr 10, 2019
View reviewed changes
cmd/diff.go Outdated Show resolved Hide resolved
hbagdi
hbagdi requested changes Apr 11, 2019
View reviewed changes
Copy link
Member

@hbagdi hbagdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments to simplify this but otherwise looks good. Thanks!

file/reader.go Outdated Show resolved Hide resolved
cmd/sync.go Outdated Show resolved Hide resolved
kong.yaml Outdated Show resolved Hide resolved
cmd/sync.go Outdated Show resolved Hide resolved
hbagdi pushed a commit that referenced this pull request Apr 13, 2019
@matthewbednarski @hbagdi
feat(file) read state from stdin when s -
c08a684 
Using the `-s` flag, `-` is a special value now to read the input from
standard input rather than a file.

Fix #8
From #11
@hbagdi
Copy link
Member

hbagdi commented Apr 13, 2019

@matthewbednarski Thank you for the contribution!
I've manually merged this in c08a684.

@hbagdi hbagdi closed this Apr 13, 2019
rainest pushed a commit that referenced this pull request Apr 21, 2021
feat: add DeepCopy() annotations to enterprise entities
5aed7b8 
From #11
rainest pushed a commit that referenced this pull request Apr 21, 2021
@matthewbednarski
feat(file) read state from stdin when s -
9b1fcb5 
Using the `-s` flag, `-` is a special value now to read the input from
standard input rather than a file.

Fix #8
From #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbagdi hbagdi hbagdi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: sync/diff command - use of '-' indicates to read from stdin
2 participants
@matthewbednarski @hbagdi