Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot set strip_path to false using config #18

Closed
struhtanov opened this issue May 27, 2019 · 1 comment · Fixed by #19
Closed

Cannot set strip_path to false using config #18

struhtanov opened this issue May 27, 2019 · 1 comment · Fixed by #19

Comments

@struhtanov
Copy link

Even if strip_path is set to false in config, the value in kong will still be true
hbagdi added a commit that referenced this issue Jun 8, 2019
@hbagdi
fix(default) allow strip_path to be set to false
8df67e5 
Breaking change:

This is a limitation of how we fill in default values for the missing
values. It is not possible in Go to determine if a value is nil vs a
zero vaule (false for boolean).

Fixes #18
@hbagdi
Copy link
Member

hbagdi commented Jun 8, 2019

This was introduced in decK 0.3.0. The fix is ready and will be released with decK 0.4.0.

@hbagdi hbagdi mentioned this issue Jun 8, 2019
Merged
@hbagdi hbagdi closed this as completed in #19 Jun 8, 2019
hbagdi added a commit that referenced this issue Jun 8, 2019
@hbagdi
fix(default) allow strip_path to be set to false
103626c 
Breaking change:

This is a limitation of how we fill in default values for the missing
values. It is not possible in Go to determine if a value is nil vs a
zero vaule (false for boolean).

Fixes #18
From #19
rainest pushed a commit that referenced this issue Apr 21, 2021
@hbagdi
fix(default) allow strip_path to be set to false
c91210e 
Breaking change:

This is a limitation of how we fill in default values for the missing
values. It is not possible in Go to determine if a value is nil vs a
zero vaule (false for boolean).

Fixes #18
From #19
@Benny-Git Benny-Git mentioned this issue Dec 28, 2021
Closed
AntoineJac pushed a commit that referenced this issue Jan 23, 2024
@hbagdi
fix(default) allow strip_path to be set to false
29c2e4a 
Breaking change:

This is a limitation of how we fill in default values for the missing
values. It is not possible in Go to determine if a value is nil vs a
zero vaule (false for boolean).

Fixes #18
From #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(default) allow strip_path to be set to false Kong/deck
2 participants
@struhtanov @hbagdi