Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 0.7.1 errors with Error: reading Kong version: No Major.Minor.Patch elements found #117

Closed
Evangelinexx opened this issue Dec 27, 2019 · 4 comments · Fixed by #118
Closed

Version 0.7.1 errors with Error: reading Kong version: No Major.Minor.Patch elements found #117

Evangelinexx opened this issue Dec 27, 2019 · 4 comments · Fixed by #118
Labels
bug Something isn't working

Comments

@Evangelinexx
Copy link

In the latest version (0.7.1), we have found that it errors out when trying to do a diff or a sync with the following error:

Error: reading Kong version: No Major.Minor.Patch elements found

This does not occur in previous versions (we are using v0.7.0 with no problems for now)

Here are examples of the commands we are running that fail with that error:

docker run --add-host localdev.test.com.au:$ip -v ${PWD}:/tmp -w /tmp hbagdi/deck:v0.7.1 diff -s development --kong-addr http://localdev.test.com.au:8001

docker run --add-host localdev.test.com.au:$ip -v ${PWD}:/tmp -w /tmp hbagdi/deck:v0.7.1 sync -s development --kong-addr http://localdev.test.com.au:8001
@hbagdi
Copy link
Member

hbagdi commented Dec 27, 2019 •
edited
Loading

Can you share the output of GET / for Kong's Admin API?

Or you can run:

deck ping

@Evangelinexx
Copy link
Author

Here:

docker run --add-host localdev.test.com.au:$ip -v ${PWD}:/tmp -w /tmp hbagdi/deck:v0.7.1 ping --kong-addr http://localdev.test.com.au:8001
Successfully connected to Kong!
Kong version:  1.4.1

hbagdi added a commit that referenced this issue Dec 27, 2019
@hbagdi
fix: correctly parse Kong's version
ab66581 
semver lib errors out if no patch is found.
Switch to ParseTolerant() which injects a `0` patch number.

Fix #117
@hbagdi hbagdi added the bug Something isn't working label Dec 27, 2019
@hbagdi hbagdi mentioned this issue Dec 27, 2019
Merged
@hbagdi
Copy link
Member

hbagdi commented Dec 27, 2019

Please downgrade to 0.7.0 for now.
I'll be releasing 0.7.2 next week with the fix included in it.

Thank you for the report!

@Evangelinexx
Copy link
Author

Thanks for the quick fix!

hbagdi added a commit that referenced this issue Dec 29, 2019
@hbagdi
fix: correctly parse Kong's version
f6a5511 
semver lib errors out if no patch is found.
Switch to ParseTolerant() which injects a `0` patch number.

Fix #117
From #118
rainest pushed a commit that referenced this issue Apr 21, 2021
@hbagdi
fix: correctly parse Kong's version
7066a2f 
semver lib errors out if no patch is found.
Switch to ParseTolerant() which injects a `0` patch number.

Fix #117
From #118
AntoineJac pushed a commit that referenced this issue Jan 23, 2024
@hbagdi
fix: correctly parse Kong's version
9dda7d0 
semver lib errors out if no patch is found.
Switch to ParseTolerant() which injects a `0` patch number.

Fix #117
From #118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correctly parse Kong's version Kong/deck
2 participants
@hbagdi @Evangelinexx