Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability reporting procedure #1729

Closed
1 task done
silvergasp opened this issue Nov 7, 2022 · 7 comments
Closed
1 task done

Vulnerability reporting procedure #1729

silvergasp opened this issue Nov 7, 2022 · 7 comments

Comments

@silvergasp
Copy link
Contributor

Related area

Security/vulnerability reporting

Hardware specification

N/A

Is your feature request related to a problem?

I think I've found a security vulnerability, but I don't want to publicly describe the problem on a GitHub issue until the problem is fixed. Having a security problem published publicly would open people up to attack.

Describe the solution you'd like

I'd like some procedures to be in place to;

NOTE: There are some templates on the links above which offer a good starting point.

I have checked existing issues, dicussion and documentation

  • I confirm I have checked existing issues, dicussion and documentation.
@cr1901
Copy link
Collaborator

cr1901 commented Nov 15, 2022

I agree something should be done about this, apparently Github now has a feature to contact project maintainers securely/directly in case of a vuln? Idk much about it tho...

@silvergasp
Copy link
Contributor Author

I wasn't aware of that. But it looks like a great option!

Link to the docs for posterity;

https://docs.github.com/en/code-security/security-advisories/repository-security-advisories/configuring-private-vulnerability-reporting-for-a-repository

@silvergasp
Copy link
Contributor Author

It appears pretty easy to setup. But it would need to be done by someone with admin privileges.

@cr1901
Copy link
Collaborator

cr1901 commented Nov 15, 2022

Well, @hathach seems to be taking a break for now, but I imagine he'll be back soon. Thanks for the link, since I completely forgot other than hearing about the new feature thirdhand :D!

@silvergasp
Copy link
Contributor Author

Yeah, I've emailed @hathach directly with directly with details of the vulnerability that I found. Got a reply mentioning that he was keen to take a look, but is currently away from his computer.

I don't think there is any need to rush into getting it fixed :). Though it would be nice to get a fix together in the next couple of weeks.

@hathach
Copy link
Owner

hathach commented Nov 16, 2022

just be back to my PC, will check this out in this week or so. Thank you for the issue/pr.

@hathach
Copy link
Owner

hathach commented Jan 7, 2023

this should be fixed by #1789, thank you @silvergasp very much for bringing this up and also making effort to add fuzzer as well and pr to integrate tinyusb to google fuzzing.

@hathach hathach closed this as completed Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants