UI: Fix missing nav links on namespace login #12478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monkeychip
approved these changes
Sep 3, 2021
hashishaw
added a commit
that referenced
this pull request
Sep 3, 2021
* Override loading behavior which breaks query params passed to API calls * Only show loading state if transition is not queryparams only * Add changelog * Skip loader if testing
hashishaw
added a commit
that referenced
this pull request
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue due to an Ember bug with sticky query params which was fixed in Ember 3.24. Since we need to backport this fix to 1.8.x, we're going to go with the workaround outlined in this comment and then revert and upgrade to Ember 3.24 for 1.9 and forward.
BEFORE
AFTER
