Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodeSelector support for injector #231

Closed
woowil opened this issue Mar 18, 2020 · 1 comment
Closed

nodeSelector support for injector #231

woowil opened this issue Mar 18, 2020 · 1 comment
Labels
chart Area: helm chart enhancement New feature or request

Comments

@woowil
Copy link

woowil commented Mar 18, 2020 •
edited
Loading

templates\injector-deployment.yaml is missing support for nodeSelector and cystom "helm patch" updates fail. We have a mixed environment with Windows and Linux nodes. The vault and injection pods are automatically created on the windows nodes. I have therefore updated "kubernetes.io/os: linux" under nodeSelector in values.yaml file for the vault pods but unable to do so for vault-injector.

Could you solve this, please.
@tvoran tvoran added chart Area: helm chart enhancement New feature or request labels Mar 19, 2020
@tvoran tvoran mentioned this issue Mar 20, 2020
Merged
@tvoran
Copy link
Member

tvoran commented Nov 20, 2020

Hi @woowil, nodeSelector support for the injector was adding in #234, and included in v0.5.0: https://github.com/hashicorp/vault-helm/blob/master/CHANGELOG.md#050-april-9th-2020

@tvoran tvoran closed this as completed Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chart Area: helm chart enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tvoran @woowil