Check the error on post-test destroy. #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were silently discarding the error instead of surfacing it when there was an error returned from our post-test destroy code responsible for tearing down infrastructure. Let's tell the user so they know infrastructure may be dangling, and can see what went wrong and ideally fix it. Fixes #571.
appilon
approved these changes
Sep 14, 2020
kmoe
approved these changes
Sep 15, 2020
paddycarver
added a commit
that referenced
this pull request
Sep 22, 2020
Backport #580 to restore pre-binary ExpectNonEmptyPlan behavior when testing. Backport #584 to use the latest terraform-exec and terraform-plugin-test to take advantage of the fixed diff output. Backport #581 to check the error on post-test destroy, warning there may be dangling resources and surfacing the error. This should bring the v1-maint branch in line with 2.0.3 in terms of functionality and bug fixes.
paddycarver
added a commit
that referenced
this pull request
Sep 22, 2020
Backport #580 to restore pre-binary ExpectNonEmptyPlan behavior when testing. Backport #584 to use the latest terraform-exec and terraform-plugin-test to take advantage of the fixed diff output. Backport #581 to check the error on post-test destroy, warning there may be dangling resources and surfacing the error. This should bring the v1-maint branch in line with 2.0.3 in terms of functionality and bug fixes.
paddycarver
added a commit
that referenced
this pull request
Sep 23, 2020
Backport #580 to restore pre-binary ExpectNonEmptyPlan behavior when testing. Backport #584 to use the latest terraform-exec and terraform-plugin-test to take advantage of the fixed diff output. Backport #581 to check the error on post-test destroy, warning there may be dangling resources and surfacing the error. This should bring the v1-maint branch in line with 2.0.3 in terms of functionality and bug fixes.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were silently discarding the error instead of surfacing it when there
was an error returned from our post-test destroy code responsible for
tearing down infrastructure. Let's tell the user so they know
infrastructure may be dangling, and can see what went wrong and ideally
fix it.
Fixes #571.