Fix spurious diff from timeouts. #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When testing and verifying that the imported state matches the applied state, we're seeing some resources report that the number of elements in the `timeouts` map don't match between the two states. Apparently, any timeouts set in the config are added to state during _import_, but aren't during a regular apply. To avoid returning this incorrectly as a diff, we're just not going to verify that.
appilon
approved these changes
Sep 11, 2020
kmoe
approved these changes
Sep 11, 2020
Closed
1 task
paddycarver
added a commit
that referenced
this pull request
Sep 11, 2020
paddycarver
added a commit
that referenced
this pull request
Sep 15, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing and verifying that the imported state matches the applied
state, we're seeing some resources report that the number of elements in
the
timeoutsmap don't match between the two states. Apparently, anytimeouts set in the config are added to state during import, but
aren't during a regular apply.
To avoid returning this incorrectly as a diff, we're just not going to
verify that.