Consider resource provider when locating expected state in ImportState acceptance test case #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that the AWS Provider is using v2.0.1 of the Plugin SDK I have verified that this change does fix the previously failing test case: $ make testacc TEST=./aws/ TESTARGS=-run='TestAccAWSVpcPeeringConnectionOptions_sameRegionDifferentAccount'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSVpcPeeringConnectionOptions_sameRegionDifferentAccount -timeout 120m
=== RUN TestAccAWSVpcPeeringConnectionOptions_sameRegionDifferentAccount
=== PAUSE TestAccAWSVpcPeeringConnectionOptions_sameRegionDifferentAccount
=== CONT TestAccAWSVpcPeeringConnectionOptions_sameRegionDifferentAccount
--- PASS: TestAccAWSVpcPeeringConnectionOptions_sameRegionDifferentAccount (37.80s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 37.860s |
paddycarver
approved these changes
Aug 26, 2020
paddycarver
added a commit
that referenced
this pull request
Aug 26, 2020
When trying to find the resource state when verifying imports, take the resource's provider into consideration. This is a backport of #522.
paddycarver
added a commit
that referenced
this pull request
Sep 4, 2020
When trying to find the resource state when verifying imports, take the resource's provider into consideration. This is a backport of #522.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #521.
The AWS provider has not quite upgraded to v2.0.0 of the SDK yet so I haven't been able to test the fix against my failing acceptance test case although the same fix against v1.14.0 succeeded.
I see no suitable unit tests to add a test case to.