Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect values for meta.SDKVersion and meta.SDKPrerelease #444

Closed
paddycarver opened this issue May 5, 2020 · 1 comment · Fixed by #448
Closed

Incorrect values for meta.SDKVersion and meta.SDKPrerelease #444

paddycarver opened this issue May 5, 2020 · 1 comment · Fixed by #448
Assignees
Labels
bug Something isn't working
Milestone

Comments

@paddycarver
Copy link
Contributor

For the 2.0.0-rc.1 release, the meta.SDKVersion got set to "2.0.0-rc.1" and the meta.SDKPrerelease got set to "". This is due to a faulty regexp in our release scripts.

Fortunately, this should only impact users that are referencing meta.SDKVersion and meta.SDKPrerelease directly. Users using meta.SDKVersionString() will receive the correct result; it's just not split into its constituent variables correctly.

We should resolve this for 2.0.0-rc.2, but because the impact is fairly minimal for the moment--most users probably won't notice--it probably doesn't justify an emergency release.

@paddycarver paddycarver added the bug Something isn't working label May 5, 2020
@paddycarver paddycarver added this to the v2.0.0 milestone May 5, 2020
@kmoe kmoe self-assigned this May 5, 2020
@ghost
Copy link

ghost commented Jun 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants