-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Verbose check #406
Remove Verbose check #406
Conversation
This currently requires mitchellh/go-testing-interface @ v1.14.1 but it could be relaxed to v1.0.3. There were some complications in the publishing, so waiting for that to be fixed so we can relax the constraint here to not force go 1.14. Edit: this is now resolved |
t.FatalCalled = true | ||
t.FatalArgs = args | ||
t.f = true | ||
testinginterface.RuntimeT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see now the data captured in the mock is removed. Honestly the 2 unit tests that use the mock are somewhat superfluous. I think I would prefer expose mitchell's lib on the SDK surface and just delete those 2 tests and mockT
altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering its a _test
package I just went for minimal change here. Its not exposed externally really and we did have testing to check if parallel was invoked, so I needed a wrapper to capture that.
2daa683
to
1070d26
Compare
@appilon the upstream issue is resolved |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
No description provided.