Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #45.
Note the corresponding code in the SDK gRPC server, which was missed out when we ported the
stopCh
implementation to terraform-plugin-go: https://github.com/hashicorp/terraform-plugin-sdk/blob/master/helper/schema/grpc_provider.go#L29I'm not completely happy with this yet because I don't have a consistent reproduction case; this code (
server.Stop
) is not run every time a Ctrl-C is issued during aterraform apply
. Leaving this here so we can either agree it's a reasonable change and merge it, or decide to investigate further.