Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept objects with DynamicPseudoType with null values #116

Merged

Conversation

kjagiello
Copy link
Contributor

@kjagiello kjagiello commented Nov 11, 2021

The value of a DynamicPseudoType should be allowed to be either unknown or null. The check for the latter was missing and this PR adds it. Let me know if there are any more tests needed.

Solves #115

@hashicorp-cla
Copy link

hashicorp-cla commented Nov 11, 2021

CLA assistant check
All committers have signed the CLA.

@paddycarver
Copy link
Contributor

paddycarver commented Nov 11, 2021

Hey @kjagiello! Thanks for the PR. :) Any chance you wouldn't mind adding a changelog entry for this? You can do that by including something like

```release-note:bug
Fixed a panic when using DynamicPseudoType attributes in an object.
```

in .changelog/116.txt.

Thanks!

@kjagiello
Copy link
Contributor Author

Of course! Added it now.

@kjagiello kjagiello force-pushed the bugfix/object-with-dynamic-null branch from 938e5be to 67a8cc9 Compare November 11, 2021 15:34
@kjagiello kjagiello force-pushed the bugfix/object-with-dynamic-null branch from 67a8cc9 to 0131d41 Compare November 11, 2021 15:34
@paddycarver paddycarver merged commit 21a2c2c into hashicorp:main Nov 11, 2021
@paddycarver
Copy link
Contributor

Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants