Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Artifacts with keep_input_artifact=false shouldn't be sent to HCP Packer #11462

Closed
nywilken opened this issue Dec 17, 2021 · 4 comments
Closed
Labels
core Core components of Packer enhancement hcp sync to jira For issues that need to be imported to Packer internal JIRA backlog
Milestone

Comments

@nywilken
Copy link
Contributor

There is a bug where setting keep_input_artifact=false registers the builder output as an image even though it has been deleted.

This will be a little tricky to address since keep_input_artifact is set on the next post processor, not the current one. We don't have a DAG so parsing whether an artifact should be saved may be challenging.

@nywilken nywilken added bug core Core components of Packer hcl2-dag labels Dec 17, 2021
@azr azr added the hcp label Dec 20, 2021
@azr
Copy link
Contributor

azr commented Dec 20, 2021

I think that this should be achievable without the dag work (in a complex manner).

@nywilken nywilken added sync to jira For issues that need to be imported to Packer internal JIRA backlog and removed hcl2-dag labels Sep 30, 2022
@github-actions
Copy link

This issue has been synced to JIRA for planning.

JIRA ID: HPR-754

@nywilken nywilken added this to the 1.8.5 milestone Nov 4, 2022
@nywilken
Copy link
Contributor Author

nywilken commented Dec 1, 2022

Closed by #11967

@nywilken nywilken closed this as completed Dec 1, 2022
@github-actions
Copy link

github-actions bot commented Jan 1, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core Core components of Packer enhancement hcp sync to jira For issues that need to be imported to Packer internal JIRA backlog
Projects
None yet
Development

No branches or pull requests

2 participants