[ui] Keyboard shortcuts to switch regions #17169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaiWithJai
approved these changes
May 12, 2023
philrenaud
force-pushed
the
17168-ui-keyboard-nav-allow-switching-between-regions
branch
from
b39e141
to
dfc9461
Compare
Ember Asset Size actionAs of dfc9461 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
philrenaud
deleted the
17168-ui-keyboard-nav-allow-switching-between-regions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
r #keyboard bindings to regions.Note: I'm making an assumption here that users have few regions in general to save on keystrokes. If, however, we expect that users commonly have 10+ regions, then I should switch this to
r 0 1instead of justr 1, lest you end up on the wrong region when you meant to go to region 10 or 11 etc. (we evaluate the buffer on keypress eagerly)