Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HBAR Rate Limit Redesign] Improive logging logic for hbarLimit related classes #3025

Open
Tracked by #2739
quiet-node opened this issue Sep 21, 2024 · 2 comments
Open
Tracked by #2739
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@quiet-node
Copy link
Member

Problem

Logging in the classes within the hbarLimiter repositories (e.g., EthAddressHbarSpendingPlanRepository, HbarSpendingPlanRepository, IPAddressHbarSpendingPlanRepository) appears to be duplicated and does not include a requestId. This makes it difficult to track logs during debugging.

Solution

Improve logging for HbarLimitter related classes

Alternatives

No response

@victor-yanev
Copy link
Contributor

victor-yanev commented Sep 21, 2024

Already fixed in Kosi’s PR #2939

@victor-yanev
Copy link
Contributor

victor-yanev commented Sep 21, 2024

Okay, nvm it seems that these changes were reverted in the PR, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Sprint Backlog
Development

No branches or pull requests

2 participants