Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set deepEqual() prototype option to true by default, not just when no options are passed #299

Closed
hueniverse opened this issue May 19, 2019 · 2 comments
Labels
breaking changes Change that can breaking existing code bug Bug or defect
Milestone

Comments

@hueniverse
Copy link
Contributor

This is clearly a bug in the way default options are set, but it does create a breaking change.

Not sure if I should revert it or not.

@hueniverse hueniverse added bug Bug or defect breaking changes Change that can breaking existing code labels May 19, 2019
@hueniverse hueniverse added this to the 6.2.3 milestone May 19, 2019
@kanongil
Copy link
Contributor

Hmm, I'm not sure. Anyway, it doesn't seem to effect the usages in the hapi modules.

Note, there is still a case where the option is unset, where you might expect it to be the default value:

Hoek.deepEqual(Object.create(null), {}, { prototype: undefined });

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking changes Change that can breaking existing code bug Bug or defect
Projects
None yet
Development

No branches or pull requests

2 participants