Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip attribute: make them work on non-inline mod #245

Open
W95Psp opened this issue Sep 5, 2023 · 0 comments
Open

skip attribute: make them work on non-inline mod #245

W95Psp opened this issue Sep 5, 2023 · 0 comments
Assignees
Labels
needs-discussion Issue that requires a discussion to make their status clear

Comments

@W95Psp
Copy link
Collaborator

W95Psp commented Sep 5, 2023

cc @franziskuskiefer

Status

We have now an include attribute and an exclude attribute.

Due to rust-lang/rust#54727, on stable, a proc macro cannot work on non-inline modules (an inline module is mod foo { ... items ... }, whereas a non-inline module is ie mod foo; with foo.rs is a file).

Our hax attributes are working with two layers: we have some proc-macros that get transformed into tool attributes but only when compiling via hax, because tool attributes are nightly.

Technically, until either tool attributes or rust-lang/rust#54727 are nightly, I don't think we can solve this issue. But, since we now support the -i flag in the cargo hax into command line, maybe this issue is not important any longer.

@W95Psp W95Psp self-assigned this Sep 5, 2023
@W95Psp W95Psp added the needs-discussion Issue that requires a discussion to make their status clear label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-discussion Issue that requires a discussion to make their status clear
Projects
No open projects
Status: No status
Development

No branches or pull requests

1 participant