Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authors list only has seperating comma for last member #74

Closed
LordMike opened this issue Feb 9, 2020 · 1 comment
Closed

Authors list only has seperating comma for last member #74

LordMike opened this issue Feb 9, 2020 · 1 comment

Comments

@LordMike
Copy link

LordMike commented Feb 9, 2020

In the image below, for a given repo (custom repo, not yet community), there is a missing seperator between the first two authors.

image

I think the issue is here, with the re-use of the seperatorElement. It can probably only be used once, and thus by "reusing" it, it's moved from its original placement. Creating a new seperator for each author would probably resolve this.

const seperateElement = document.createElement("div");
seperateElement.className = "seperator";
seperateElement.innerText = ",";
this.authors.forEach(author => {
const authorElement = document.createElement("a");
authorElement.href = `https://github.com/${author.replace("@", "")}`;
authorElement.target = "_blank";
authorElement.className = "author";
authorElement.innerText = author.replace("@", "");
authors.push(authorElement);
authors.push(seperateElement);

Extra, the DOM for the authors tag:

image

@hacs-bot
Copy link

hacs-bot bot commented Feb 9, 2020

Make sure you have read the issue guidelines and that you filled out the entire template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant