Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit multiple option handling, particularly --peer #4519

Closed
christophermaier opened this issue Jan 30, 2018 · 2 comments
Closed

Revisit multiple option handling, particularly --peer #4519

christophermaier opened this issue Jan 30, 2018 · 2 comments
Labels
Documentation Flags an issue / PR for attention by the technical documentation team Focus: CLI Related to the Habitat CLI (core/hab) component Type: Bug Issues that describe broken functionality

Comments

@christophermaier
Copy link
Contributor

christophermaier commented Jan 30, 2018

In the past, we've used a space-delimited list of peer addresses as the value to the --peer option when starting up a Supervisor (including in our own provisioning (private link). The way the code is written, and based on how Clap handles argument parsing (which may have changed recently?), only the first peer address is actually used.

Passing the --peer flag multiple times, however, successfully accumulates all peer addresses.

We should survey our documentation for --peer in particular, but all multi-valued options across our CLI, to ensure that users are not confused (initially, there was some confusion over whether comma-delimited values would work, too). We should also update our provisioning code accordingly.

@rsertelon
Copy link
Contributor

There's --bind that would benefit from that too (see #2221 and #3106).

Also, I've opened an issue on the clap-rs crate repository about these issues, where the maintainer points to what you're suggesting (clap-rs/clap#1125)

@mpeck
Copy link
Contributor

mpeck commented Nov 30, 2018

multiple options can be specified using a space delimited list or by specifying the option multiple times, hab sup run --peer 1.1.1.1 2.2.2.2 3.3.3.3 or hab sup run --peer 1.1.1.1 --peer 2.2.2.2 --peer 3.3.3.3

@christophermaier christophermaier added Focus: CLI Related to the Habitat CLI (core/hab) component Type: Bug Issues that describe broken functionality and removed A-cli labels Jul 24, 2020
@christophermaier christophermaier added Documentation Flags an issue / PR for attention by the technical documentation team and removed A-documentation labels Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Flags an issue / PR for attention by the technical documentation team Focus: CLI Related to the Habitat CLI (core/hab) component Type: Bug Issues that describe broken functionality
Projects
None yet
Development

No branches or pull requests

3 participants