fix: support for numpy 2.0 #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiterallyUniqueLogin
approved these changes
Jun 24, 2024
|
thanks!! Trusted publishing is just a more secure way for us to publish to pypi Also, the new system uses github environments, so that admins of trtools will need to approve each pypi release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the resolution of brentp/cyvcf2#307, all of our dependencies now have support for numpy 2.0! Let's remove the upper bound requirement
This PR also makes some small changes to the release workflow to allow us to use trusted pypi publishing. Because of these changes, we will need to set up trusted publishing before we publish a new version of trtools. Otherwise, the release workflow will break upon an attempted publication