Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to easily experiment with different server implementations #5470

Closed
thefallentree opened this issue Jun 24, 2022 · 1 comment
Closed

Comments

@thefallentree
Copy link

Hello, right now golang grpc starts a go-routine on every single request, as seen here:

wg.Add(1)

I want to experiment on some ideas like "use a go worker pool and an channel to propagate back pressure to client " Which looks like it requires a new Server struct implementation. But due to Server is a concrete struct, there is no way for me to provide a override Server implementation easily without modifying the grpc source code. I can't just copy server.go either, because it is using some "internal" packages .

what's my best options here?

@dfawley
Copy link
Member

dfawley commented Jun 28, 2022

If you're interested in contributing improvements to our server implementation, let us know. Otherwise, what you describe could only be achieved when/if we implement this pending gRFC: grpc/proposal#103

@dfawley dfawley closed this as completed Jun 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants