Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.0.0 and later is no OSGi bundle anymore #106

Closed
Lana11s opened this issue Nov 23, 2021 · 2 comments · Fixed by #113
Closed

Version 3.0.0 and later is no OSGi bundle anymore #106

Lana11s opened this issue Nov 23, 2021 · 2 comments · Fixed by #113

Comments

@Lana11s
Copy link
Contributor

Lana11s commented Nov 23, 2021

Describe the bug
Since version 3.0.0 the java-dataloader is no valid OSGi bundle anymore.
The MANIFEST.MF file does not contain the required entries anymore.

Version 2.2.3 was a valid bundle and was running fine in an OSGi runtime.

To Reproduce
Load java-dataloader in an OSGi runtime, like Eclipse or Apache Felix.

Expected
Valid OSGi bundle with valid import/export.

old MANIFEST.MF:

Manifest-Version: 1.0
Export-Package: org.dataloader;version="2.2.3";uses:="org.dataloader.s
 tats",org.dataloader.impl;version="2.2.3";uses:="org.dataloader",org.
 dataloader.stats;version="2.2.3"
Bundle-SymbolicName: org.dataloader.java-dataloader
Bundle-Version: 2.2.3
Bundle-Name: java-dataloader
Bundle-ManifestVersion: 2
Bnd-LastModified: 1566716677000
Import-Package: org.dataloader;version="[2.2,3)",org.dataloader.impl;v
 ersion="[2.2,3)",org.dataloader.stats;version="[2.2,3)"
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))"
Created-By: 1.8.0_212 (AdoptOpenJDK)
Tool: Bnd-3.2.0.201605172007

new MANIFEST.MF:

Manifest-Version: 1.0
Automatic-Module-Name: com.graphql-java
@Lana11s Lana11s changed the title Version 3.0.0 and later is no OSGi anymore Version 3.0.0 and later is no OSGi bundle anymore Nov 23, 2021
@bbakerman
Copy link
Member

A PR maybe to make it might help. I dont use OSGi any more (I swore off the stuff 5 years ago ;)

@Lana11s
Copy link
Contributor Author

Lana11s commented Mar 19, 2022

Hello @bbakerman, I created a PR here: #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants