Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch jobs from jobqueue on rethinkdb reconnect #86

Open
mohit5540 opened this issue Aug 14, 2018 · 3 comments
Open

fetch jobs from jobqueue on rethinkdb reconnect #86

mohit5540 opened this issue Aug 14, 2018 · 3 comments

Comments

@mohit5540
Copy link

@grantcarthew @zllovesuki

With reference to #85, #72
we are able to reconnect rethinkdb through 'pingInterval' option. Now the problem is, even though rethinkdb gets connected, JobQueue does not start taking jobs again. script needs to restart again.

@grantcarthew I know you are working on other project at the moment, but some help in this regard will be highly appreciated.

Thanks

@grantcarthew
Copy link
Owner

Hi again @mohit5540,

In the best possible way I would like you to be aware of this blog article: I thought I understood open source, I was wrong

With that in mind I am very happy to add maintainers (collaborators) to the project to prevent the project being fragmented.

I believe most of the functionality you are after is with the change-feed-reconnect that is discussed in #77. This will fix the re-connection issues. Once re-connect is working then a simple call to queueProcess.restart will restart processing.

I have created a PR #87 that will add rethinkdb-changefeed-reconnect. Either work with this or create your own. If you want to keep the work to a minimum you could simply expose queueProcess.restart as a public API method so you can call it yourself.

You will need to call queueProcess.restart on reconnect. If the rethinkdb-changefeed-reconnect doesn't have a related event then an internal connection status poll or something like that would do the job. That's were you come in 👍 .

Feel free to keep asking questions. Happy to help were I can.

@grantcarthew
Copy link
Owner

grantcarthew commented Aug 15, 2018

I just had a look and the Queue.resume public API call could work if you want to just restart processing. A Queue.restart would be a good addition to the package though.

@grantcarthew
Copy link
Owner

ping @mohit5540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants