Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop dependency on GLM #60

Closed
nalimilan opened this issue Jul 1, 2022 · 2 comments
Closed

Drop dependency on GLM #60

nalimilan opened this issue Jul 1, 2022 · 2 comments

Comments

@nalimilan
Copy link

I was wondering what would be needed to drop the (optional) dependency on GLM. glm.jl seems to contain methods which are type piracy, which isn't great. Also, with JuliaStats/GLM.jl#339 we'd like to drop TableRegressionModel in favor of directly returning LinearModel and GeneralizedLinearModel objects. Would that be a problem for CovarianceMatrices?

Maybe that could be the occasion to fix #47 and JuliaStats/GLM.jl#42 by implementing the necessary parts in GLM? Could we also make this more generic so that it works for other packages that implement the StatsAPI/StatsModels API?
@gragusa
Copy link
Owner

gragusa commented Jul 13, 2022

I am working on it. I will draft a pull request with the necessary changes. My for https://github.com/gragusa/GLM.jl has all the necessary changes to allow CovarianceMatrices.jl to drop the dependence on GLM.jl.

@gragusa
Copy link
Owner

gragusa commented Mar 29, 2024

Closed by #61

@gragusa gragusa closed this as completed Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gragusa @nalimilan