Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Response APIs to async #1309

Closed
4 tasks done
Tracked by #428
inancgumus opened this issue May 6, 2024 · 1 comment
Closed
4 tasks done
Tracked by #428

Migrate Response APIs to async #1309

inancgumus opened this issue May 6, 2024 · 1 comment
Assignees
Labels
async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes

Comments

@inancgumus
Copy link
Member

inancgumus commented May 6, 2024

Tasks

  1. async mapping refactor stability
    inancgumus

What

Migrate the following APIs according to the How section in #428:

Class Method Current k6 Return PW return
Response allHeaders Record<string,string> Promise<{[key:string]:string;}>
Response body ArrayBuffer Promise
Response headerValue string|null Promise<null|string>
Response headerValues string[] Promise<Array>
Response headersArray Array<{name:string;value:string}> Promise<Array<{name:string;value:string;}>>
Response json any Promise
Response securityDetails SecurityDetailsObject|null Promise<null|{issuer?:string;protocol?:string;subjectName?:string;validFrom?:number;validTo?:number;}>
Response serverAddr {ipAddress:string;port:number}|null Promise<null|{ipAddress:string;port:number;}>
Response size {body:number;headers:number} not found in Playwright

For details on the Why and How, check the overarching issue in #428.

@inancgumus inancgumus added async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes labels May 6, 2024
@inancgumus inancgumus self-assigned this May 31, 2024
@inancgumus inancgumus mentioned this issue Jun 3, 2024
3 tasks
@ankur22 ankur22 self-assigned this Jun 6, 2024
@allansson
Copy link

The type defintions for this are already async.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes
Projects
None yet
Development

No branches or pull requests

3 participants