From 2d61d409bf6393e10fe7bc94b839b43f478caa40 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C4=B0nan=C3=A7=20G=C3=BCm=C3=BC=C5=9F?= Date: Tue, 22 Aug 2023 16:29:54 +0300 Subject: [PATCH] Refactor clearCookies to return error --- api/browser_context.go | 2 +- common/browser_context.go | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/api/browser_context.go b/api/browser_context.go index bcee7756c..f8aaaada1 100644 --- a/api/browser_context.go +++ b/api/browser_context.go @@ -9,7 +9,7 @@ type BrowserContext interface { AddCookies(cookies goja.Value) error AddInitScript(script goja.Value, arg goja.Value) error Browser() Browser - ClearCookies() + ClearCookies() error ClearPermissions() Close() Cookies() ([]any, error) // TODO: make it []Cookie later on diff --git a/common/browser_context.go b/common/browser_context.go index 7aa723482..2414a4d8b 100644 --- a/common/browser_context.go +++ b/common/browser_context.go @@ -479,15 +479,16 @@ func (b *BrowserContext) AddCookies(cookies goja.Value) error { } // ClearCookies clears cookies. -func (b *BrowserContext) ClearCookies() { +func (b *BrowserContext) ClearCookies() error { b.logger.Debugf("BrowserContext:ClearCookies", "bctxid:%v", b.id) clearCookies := storage. ClearCookies(). WithBrowserContextID(b.id) if err := clearCookies.Do(b.ctx); err != nil { - k6ext.Panic(b.ctx, "clearing cookies: %w", err) + return fmt.Errorf("clearing cookies: %w", err) } + return nil } // Cookies is not implemented.