Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Returning Partial Results #899

Closed
joe-elliott opened this issue Aug 20, 2021 · 1 comment
Closed

Support Returning Partial Results #899

joe-elliott opened this issue Aug 20, 2021 · 1 comment
Assignees
Milestone

Comments

@joe-elliott
Copy link
Member

joe-elliott commented Aug 20, 2021

Is your feature request related to a problem? Please describe.
Occasionally we see intermittent failures to query traces due to a single block having issues. These issues could be data corruption or occassionally just GCS misbehaving. Currently this results in a 500 even though it's quite possible we have correctly retrieved the trace.

Describe the solution you'd like
In the above case let's return whatever we happen to have retrieved along with a simple warning. Something like:

Potential partial results. Failed to query block <block id>. 

Note: Will require some coordination with the Grafana team to add support for the warning.

@joe-elliott joe-elliott added this to the v1.2 milestone Aug 20, 2021
@joe-elliott
Copy link
Member Author

Thoughts:

  1. Should be configurable to max number of blocks that can fail
  2. Need to be able to alert/watch it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants