Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Zipkin Client/Server Spans #682

Closed
joe-elliott opened this issue May 3, 2021 · 0 comments · Fixed by #687
Closed

Support Zipkin Client/Server Spans #682

joe-elliott opened this issue May 3, 2021 · 0 comments · Fixed by #687

Comments

@joe-elliott
Copy link
Member

Is your feature request related to a problem? Please describe.
According to the Zipkin spec the client and server spans should share the same id:
https://zipkin.io/zipkin/2.11.3/zipkin/zipkin2/Span.html#shared--

When an RPC trace is client-originated, it will be sampled and the same span ID is used for the server side. However, the server shouldn't set span.timestamp or duration since it didn't start the span.

This breaks the Grafana UI b/c it does not expect two spans to have the same ID.

Describe the solution you'd like
Dedupe span IDs on query. Here is sample code from Jaeger:

https://github.com/jaegertracing/jaeger/blob/master/model/adjuster/span_id_deduper.go#L24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant