Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Zone Aware Replication cli Flags #3877

Closed
KyriosGN0 opened this issue Jul 17, 2024 · 2 comments · Fixed by #3881
Closed

Support Zone Aware Replication cli Flags #3877

KyriosGN0 opened this issue Jul 17, 2024 · 2 comments · Fixed by #3881

Comments

@KyriosGN0
Copy link
Contributor

Is your feature request related to a problem? Please describe.
in our org we use 3 AZ for mimir and we would like to be able do that with Tempo
Describe the solution you'd like
Ability to specify an AZ in cli flag like -ingester.availability-zone
Describe alternatives you've considered
use ENV var (but as we use helm chart its not possible)
Additional context

@KyriosGN0
Copy link
Contributor Author

@zalegrala @joe-elliott, i've seen we parse the Cli flags here
and we use default flags in ring.lifecyclerConfig which already has this cli flag defined here
does this mean i just need to export this flag in Tempo cli ? or is there anything else needed ?

@joe-elliott
Copy link
Member

That is correct. If you'd like to expose that config option you simply need to add a line in RegisterFlagsAndApplyDefaults

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants