Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve /flush handler #355

Closed
joe-elliott opened this issue Nov 19, 2020 · 0 comments · Fixed by #526
Closed

Improve /flush handler #355

joe-elliott opened this issue Nov 19, 2020 · 0 comments · Fixed by #526

Comments

@joe-elliott
Copy link
Member

joe-elliott commented Nov 19, 2020

Is your feature request related to a problem? Please describe.
The /flush handler on the ingesters will correctly force flush all traces to the backend, but it will not stop the ingester from receiving anything new. We should provide a parameter that allows the user to both flush and force the ingesters to stop accepting traffic. This will be required when performing certain operational procedures like scaling down ingesters.

Describe the solution you'd like
The flush handler should be extended to take a parameter that causes the ingester to:

  • Remove itself from the ring
  • Stop ingesting new traces
  • Force flush everything to the backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant