Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all search case-sensitive #1547

Closed
mdisibio opened this issue Jul 5, 2022 · 0 comments · Fixed by #1553
Closed

Make all search case-sensitive #1547

mdisibio opened this issue Jul 5, 2022 · 0 comments · Fixed by #1553
Assignees
Milestone

Comments

@mdisibio
Copy link
Contributor

mdisibio commented Jul 5, 2022

Tempo currently has different case sensitivity when searching different data: recent traces (ingesters) is case-insensitive, while backend blocks are case-sensitive. This is not intentional and leads to inconsistent search results, even the same query can give different results over time as a trace moves from the ingesters to the backend.

The consensus is that case-sensitive is the better approach. This also includes the autocomplete lookups, for tags and tag values. They currently always lower-case, and they should preserve the original case.

@mdisibio mdisibio added this to the v1.5 milestone Jul 5, 2022
@mdisibio mdisibio self-assigned this Jul 5, 2022
@mdisibio mdisibio changed the title Make ingester search case-sensitive Make all search case-sensitive Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant