Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override grpc_server_ping_without_stream_allowed default to true #4386

Closed
owen-d opened this issue Sep 27, 2021 · 3 comments
Closed

Override grpc_server_ping_without_stream_allowed default to true #4386

owen-d opened this issue Sep 27, 2021 · 3 comments
Labels
low-hanging-fruit Helpful additions of limited scope stale A stale issue or PR that will automatically be closed.

Comments

@owen-d
Copy link
Member

owen-d commented Sep 27, 2021

This is a regular pain point that users experience (i.e. #4375). I believe we should change this to true even though it changes the default behavior in the weaveworks server config. Notably, we override this in all our clusters (#4182) and changing the default should ensure better out of the box usage.

@owen-d
Copy link
Member Author

owen-d commented Sep 27, 2021

This is similar (identical?) to what was done in Cortex: cortexproject/cortex#4168

@owen-d owen-d added the low-hanging-fruit Helpful additions of limited scope label Nov 12, 2021
@pstibrany
Copy link
Member

I believe this was done in #4435.

@stale
Copy link

stale bot commented Mar 2, 2022

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Mar 2, 2022
@stale stale bot closed this as completed Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-hanging-fruit Helpful additions of limited scope stale A stale issue or PR that will automatically be closed.
Projects
None yet
Development

No branches or pull requests

2 participants