feat(blooms): limit bloom size during creation #12796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
github-actions
bot
added
the
type/docs
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
chaudum
reviewed
Apr 25, 2024
docs/sources/shared/configuration.md
Outdated
| # generated bloom filter exceeds this size will be discarded. A value of 0 sets | ||
| # an unlimited size. Default is 100MB. | ||
| # CLI flag: -bloom-compactor.max-bloom-size | ||
| [bloom_compactor_max_bloom_size: <int> | default = 100MB] |
There was a problem hiding this comment.
Should we set the default to the same value as MaxQueryPageSize, which is 64MiB?
There was a problem hiding this comment.
Yeah, I can do that 👍
edit: It's kind of a pain to align them to a single source of truth (they also use two different bytesize impls... yuck), so I'm just going to leave it as is. I also like the idea of having it above the default filter level a bit so we can change the read path slightly without reindexing.
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
…creation-size Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
chaudum
approved these changes
Apr 26, 2024
This was referenced May 6, 2024
This was referenced Jun 10, 2024
This was referenced Jul 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to short-circuit bloom creation when the constructed bloom exceeds a certain size. Should help OOM prevention creating blooms for the long-tail of series which have tons of data.
This is a stop-gap fix for a more effective solution (better stream sharding, splitting blooms, etc)