Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What (if any) limits should be applied to the default Helm installation #1200

Closed
slim-bean opened this issue Oct 25, 2019 · 3 comments
Closed

What (if any) limits should be applied to the default Helm installation #1200

slim-bean opened this issue Oct 25, 2019 · 3 comments
Assignees
@sandeepsukhani
Labels
component/loki keepalive An issue or PR that will be kept alive and never marked as stale.

Comments

@slim-bean
Copy link
Collaborator

The v0.4.0 release introduced finer grained limit controls on Loki for both reads and writes via PR #948, however we have seen since release that the defaults are lower than traffic users are sending and their clients are getting rate limited.

Should we raise the limits on ingestion for the Helm installation? Or remove the limit completely?
@stale
Copy link

stale bot commented Dec 12, 2019

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Dec 12, 2019
@cyriltovena cyriltovena added the keepalive An issue or PR that will be kept alive and never marked as stale. label Dec 13, 2019
@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Dec 13, 2019
@cyriltovena
Copy link
Contributor

@sandlis can you take this one, when you can ? Thanks !

@slim-bean
Copy link
Collaborator Author

We changed the behavior of rate limited logs to be retried (not dropped) I don't think this is an issue anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandeepsukhani sandeepsukhani

Labels
component/loki keepalive An issue or PR that will be kept alive and never marked as stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cyriltovena @sandeepsukhani @slim-bean