Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn and discard any label equal to the reserved #3155

Closed
Tracked by #3117
codebien opened this issue Jun 29, 2023 · 2 comments · Fixed by #3162
Closed
Tracked by #3117

Warn and discard any label equal to the reserved #3155

codebien opened this issue Jun 29, 2023 · 2 comments · Fixed by #3162
Assignees
@olegbespalov
Labels
cloud
Milestone
v0.46.0

Comments

@codebien
Copy link
Contributor

codebien commented Jun 29, 2023 •
edited by olegbespalov
Loading

What?

Figure out what reserved labels are and discard their usage with a warning.

Why?

Labels like __name__ and test_run_id are labels used by the k6 cloud backend, so if a test defines a set of tags that contains one of them, it will generate a conflict.
@codebien codebien mentioned this issue Jun 29, 2023
Closed
@codebien codebien added the cloud label Jun 29, 2023
@codebien codebien added this to the v0.46.0 milestone Jun 29, 2023
@olegbespalov olegbespalov self-assigned this Jun 29, 2023
@mstoykov
Copy link
Contributor

Wouldn't it make more sense to just not have those as labels?

@olegbespalov
Copy link
Contributor

Wouldn't it make more sense to just not have those as labels?

@mstoykov could you please elaborate? Do you mean pre-set them?

@olegbespalov olegbespalov mentioned this issue Jul 4, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olegbespalov olegbespalov

Labels
cloud
Projects
None yet
Milestone
v0.46.0
Development

Successfully merging a pull request may close this issue.

feat: catch, discard & warn about the labels that have reserved names grafana/k6
3 participants
@mstoykov @codebien @olegbespalov