From f048a2794d697c3ea1eaa3614bdcb32f482da794 Mon Sep 17 00:00:00 2001 From: Oleg Bespalov Date: Thu, 11 Jan 2024 13:24:17 +0100 Subject: [PATCH] Completely remove experimental GRPC module --- js/jsmodules.go | 1 - js/modules/k6/grpc/grpc.go | 21 +-------------------- 2 files changed, 1 insertion(+), 21 deletions(-) diff --git a/js/jsmodules.go b/js/jsmodules.go index 3e0b1e33b80..000923ea1ed 100644 --- a/js/jsmodules.go +++ b/js/jsmodules.go @@ -34,7 +34,6 @@ func getInternalJSModules() map[string]interface{} { "k6/experimental/redis": redis.New(), "k6/experimental/webcrypto": webcrypto.New(), "k6/experimental/websockets": &expws.RootModule{}, - "k6/experimental/grpc": grpc.NewExperimental(), "k6/experimental/timers": timers.New(), "k6/experimental/tracing": tracing.New(), "k6/experimental/browser": browser.New(), diff --git a/js/modules/k6/grpc/grpc.go b/js/modules/k6/grpc/grpc.go index b4d283347e4..8d9c4227509 100644 --- a/js/modules/k6/grpc/grpc.go +++ b/js/modules/k6/grpc/grpc.go @@ -4,7 +4,6 @@ package grpc import ( "errors" "fmt" - "sync" "github.com/dop251/goja" "github.com/mstoykov/k6-taskqueue-lib/taskqueue" @@ -16,9 +15,7 @@ import ( type ( // RootModule is the global module instance that will create module // instances for each VU. - RootModule struct { - warnAboutExperimental *sync.Once - } + RootModule struct{} // ModuleInstance represents an instance of the GRPC module for every VU. ModuleInstance struct { @@ -38,13 +35,6 @@ func New() *RootModule { return &RootModule{} } -// NewExperimental returns a pointer to a new RootModule instance. -func NewExperimental() *RootModule { - return &RootModule{ - warnAboutExperimental: &sync.Once{}, - } -} - // NewModuleInstance implements the modules.Module interface to return // a new instance for each VU. func (r *RootModule) NewModuleInstance(vu modules.VU) modules.Instance { @@ -53,15 +43,6 @@ func (r *RootModule) NewModuleInstance(vu modules.VU) modules.Instance { common.Throw(vu.Runtime(), fmt.Errorf("failed to register GRPC module metrics: %w", err)) } - if r.warnAboutExperimental != nil { - r.warnAboutExperimental.Do(func() { - vu.InitEnv().Logger.Warn( - "k6/experimental/grpc is now part of the k6 core, please change your imports to use k6/net/grpc instead." + - " The k6/experimental/grpc will be removed in k6 v0.51.0", - ) - }) - } - mi := &ModuleInstance{ vu: vu, exports: make(map[string]interface{}),