Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the amount of full page reloads in playlist mode. #11429

Closed
bergquist opened this issue Mar 29, 2018 · 4 comments
Closed

Reduce the amount of full page reloads in playlist mode. #11429

bergquist opened this issue Mar 29, 2018 · 4 comments

Comments

@bergquist
Copy link
Contributor

bergquist commented Mar 29, 2018

When the playlist is complete Grafana will do a full page reload to get an updated version of the playlist and avoid potential memory leaks. The full page refresh can feel flashy and feel distractive compared to a normal cycle between playlist items.

I think we can update the playlist every cycle without a full page reload and only trigger full page reloads every X playlist cycles.

@bergquist bergquist added this to the 5.2 milestone Mar 29, 2018
@Stef3478
Copy link

We are running a Grafana playlist on a raspberry pi and during the full page reload it flashes white for some time, very distractive indeed. Would love to see a solution for this as well.

@delfuego
Copy link

Just wanted to chime in, though, to mention that as of right now, many folks (myself included) use playlists to force a full page reload because of memory leaks... so we still very much need that to happen, at least until memory leaks can be addressed. As it stands, playlists are the only way to run Grafana on many digital media player signage devices (e.g., Brightsign players) without the memory leaks causing total failure within hours...

@bergquist bergquist modified the milestones: 5.4-beta1, 5.5 Nov 12, 2018
@torkelo torkelo modified the milestones: 5.5, 6.0-beta1, 6.0 Jan 10, 2019
@torkelo
Copy link
Member

torkelo commented Jan 10, 2019

this should be very easy for anyone to contribute, relevant code is here:
relevant code is here:
https://github.com/grafana/grafana/blob/master/public/app/features/playlist/playlist_srv.ts#L22

change it to only do a full page reload every 3rd or 5th cycle?

@torkelo torkelo removed this from the 6.0 milestone Jan 10, 2019
@aocenas
Copy link
Member

aocenas commented Jan 18, 2019

I will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants