Some ads are not blocked

[ghost]

Hello @gorhill

I do know that this isn't really an adblock extension. However when searching the term nike some ads are now popping up. The ads are not my main concern but I'm wondering if this is an indication that not everything is being blocked properly using httpsb.

[gorhill]

wondering if this is an indication that not everything is being blocked properly using httpsb

Can you clarify your thought?

[jonvuri]

He might be referring to the recent regression of chrome-instant ads. I've noticed this too. If you search using the omnibox, your search can actually have multiple sources. If you type your query in and submit it very quickly, it will be submitted as a normal search and the results returned. The url will look like this:

https://www.google.com/search?q=nike

However if you type your search into the omnibox and then wait half a second or so, you will get search suggestions - the "instant" functionality - and when you press enter to submit it, the search will be submitted with some extra chrome-instant info to a different endpoint. The url will look something like this:

https://www.google.com/webhp?sourceid=chrome-instant#q=nike

Element hiding filters work on the normal search page. For some reason they have stopped working on the chrome-instant page.

[gorhill]

This could be related to gorhill/uBlock#13. I didn't bring the fix to HTTPSB yet.

All the links above I see nothing wrong, no ads. I need to see what you see, i.e. screenshots.

And regarding "not everything is being blocked properly using httpsb", cosmetic filters is just about hiding DOM elements, not about blocking anything. If there is a bug in the cosmetic filtering, this is completely unrelated to net filtering (which can be verified using the browser's Network tab in the developer console).

[jonvuri]

Just clicked the two links in my post above, this is what I get (respectively):

[jonvuri]

Filters:

[ghost]

I can confirm that in the recent update the omnibox search results are now blocking the ads. Thank you for the fix @gorhill.

Edit: Sorry for radio silence on this issue.

[jonvuri]

Yep, seems to be working for me too.