Skip to content
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.

Adblock Plus whitelist filters is broken in 0.9.2. #262

Closed
skudo12 opened this issue May 11, 2014 · 4 comments
Closed

Adblock Plus whitelist filters is broken in 0.9.2. #262

skudo12 opened this issue May 11, 2014 · 4 comments

Comments

@skudo12
Copy link

skudo12 commented May 11, 2014

Test the site adguard.com . Broken in 0.9.2 but not in 0.9.1

@gorhill
Copy link
Owner

gorhill commented May 11, 2014

What I see:

  • Site broken in v 0.9.0.0 (ABP block filters working)
  • Site not broken in 0.9.1.1 (because of bug Adblock+ complex filters not working #258, ABP block filter not working)
  • Site broken in v 0.9.1.2 (ABP block filters working)

The filter @@||adguard.com^$~third-party which would prevent the Adguard site from being broken is not supported. Currenttly, third-party is supported, but ~third-party is not supported. So it's not that whitelist filters are broken, but rather that the required whitelist filter is not supported.

Workaround is to use a scope for adguard.com and disable ABP filtering for that scope.

@gorhill
Copy link
Owner

gorhill commented May 11, 2014

Since it is about an unsupported filter as of now, this is really a dup of #231.

@gorhill gorhill closed this as completed May 11, 2014
@skudo12
Copy link
Author

skudo12 commented May 11, 2014

Oh, I thought it's the whitelist filter that fixed it. Sorry, I thought there is a whitelist in the filters that prevent the breakage of the site.

@gorhill
Copy link
Owner

gorhill commented May 11, 2014

There is a whitelist, but not all filter options are supported (~third-party here)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants