Skip to content
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.

cookies dropped randomly since yesterday #257

Closed
anarcat opened this issue May 9, 2014 · 8 comments
Closed

cookies dropped randomly since yesterday #257

anarcat opened this issue May 9, 2014 · 8 comments

Comments

@anarcat
Copy link

anarcat commented May 9, 2014

it seems that the 0.9.1.0, instead of fixing #255, actually created the problem for me. things used to work pretty well in the past, but ever since that upgrade (I am guessing: the upgrade was automated and it only noticed the problem today), i get randomly logged out of certain sites I am logged in to.

those sites are allowed in the global context, if that makes any difference.

i'm ready to help debug this to the fullest extent, as this makes the plugin pretty much unusable right now.

this is httpsb 0.9.1.0 on Chromium Version 34.0.1847.132 Built on Debian 7.5, running on Debian jessie/sid (265804)

@gorhill
Copy link
Owner

gorhill commented May 9, 2014

I need to try and reproduce it:

  • A site where the bug occurs
  • The rules for that site, and in which context
  • The state of the matrix for behind-the-scene context

meanwhile I am going to give a close look to the code to see if I spot something.

Also:

  • Is "Delete cookies" enabled?
  • Is "Delete session cookies after..." enabled?

@anarcat
Copy link
Author

anarcat commented May 9, 2014

the bug happens on https://id.koumbit.net/

the cookie is simply not sent to the server for some reason.

the rules for that site are in the global context:

*
    whitelist
        * anarc.at
        * koumbit.net
        * orangeseeds.org
        * reseaulibre.ca
        image *
        stylesheet *
        sub_frame debian.org
        sub_frame koumbit.net
        sub_frame orangeseeds.org
    blacklist
        sub_frame *
        * *

behind the scenes was all whitelisted when the problem happens, now i went back to a site-specific whitelist.

chromium-behind-the-scene
    whitelist
        * *
    blacklist
        * *

delete cookies is not enabled in any way.

@anarcat
Copy link
Author

anarcat commented May 9, 2014

also note that if i browse the site continuously, it doesn't seem to kick me out. it feels like there's a timeout somewhere, as "Delete session cookies after..." was enabled (yet it's not).

@anarcat
Copy link
Author

anarcat commented May 9, 2014

also - changing the "behind the scene" matrix to a site-specific whitelist doesn't help in fixing the behavior. i really feel like something changed regarding the handling of cookies, this maybe?

61615fb#diff-2650fb3e14b7f42d68a8766269c54434L33

or this?

61615fb#diff-b202ac292bbe20a1cbf2a99dad662d52R352

@gorhill
Copy link
Owner

gorhill commented May 9, 2014

Ugh.. I think I got it, I made a mistake and reversed the logic about when session cookies should be deleted.

@anarcat
Copy link
Author

anarcat commented May 9, 2014

hehe, maybe we found the same thing at the same time :p

@gorhill
Copy link
Owner

gorhill commented May 9, 2014

Problem is this line:

Date.now() + 60000;

Should be:

0;

If I cared to comment what that piece of code did, I would have realized my mistake. Will fix ASAP.

@gorhill gorhill closed this as completed in 9ce3d9a May 9, 2014
@anarcat
Copy link
Author

anarcat commented May 9, 2014

thanks so much, amazing response time!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants