Skip to content
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.

Wishlist: Add a revoke for site button. #166

Closed
skudo12 opened this issue Jan 22, 2014 · 8 comments
Closed

Wishlist: Add a revoke for site button. #166

skudo12 opened this issue Jan 22, 2014 · 8 comments
Assignees
Milestone

Comments

@skudo12
Copy link

skudo12 commented Jan 22, 2014

The current erase will erase all temporary rules. I suggest to add a button that will only erase temporary rule for the current site. Just an improvement.

@gorhill
Copy link
Owner

gorhill commented Jan 22, 2014

I suspect I will torture myself endlessly trying to find the proper icon from FontAwesome to use for this action.

@skudo12
Copy link
Author

skudo12 commented Jan 22, 2014

Lol. I will to try find some when I have some free time.

@skudo12
Copy link
Author

skudo12 commented Jan 23, 2014

How about changing the current erase icon to the clear the current site/domain temporaryt rule and add this broom icon for the erase all temporary rule. https://www.iconfinder.com/icons/38988/clear_edit_sweep_sweeper_icon#size=128

@gorhill
Copy link
Owner

gorhill commented Jan 23, 2014

https://www.iconfinder.com/icons/38988/clear_edit_sweep_sweeper_icon#size=128

I prefer to stick with what http://fontawesome.io/ has to offer. There are great advantages for using font-based icons, which are easy scaling and colouring. I chose to go the FontAwesome route because I ended up spending way too much time in Gimp, Inkscape, etc. and this was quite tedious whenever I wanted to re-colour or re-scale etc. With FontAwesome, I just need to play with CSS directives and that takes care of the color, scale, etc.

@skudo12
Copy link
Author

skudo12 commented Jan 24, 2014

Then how about the trash icon in fontawesome. Trash for remove all and then erase for per site.

@gorhill
Copy link
Owner

gorhill commented Jan 27, 2014

I created a local version which opens a popup when user click, from which the user can choose whether to delete temporary rules for current matrix or all. I think I will make the popup come up when the mouse hovers over the button so as to avoid an extra click.

Side effect benefits I like with this solution:

  • No need to figure a new icon.
  • The popup acts as a tooltip, giving the user a clue about the purpose of the icon.

@gorhill
Copy link
Owner

gorhill commented Jan 29, 2014

Ok no need for poup menu, I just used a trick which is made possible by font-based icons: I used multiple small replica of the eraser icon as if one single icon. So the multiple little erasers convey the idea that this will erase all temporary rules, while the single eraser convey the idea that this will erase only what is currently visible in the matrix.

@ghost ghost assigned tailHey Jan 29, 2014
@gorhill
Copy link
Owner

gorhill commented Jan 31, 2014

Fixed in a6a9dcf.

@gorhill gorhill closed this as completed Jan 31, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants