Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm installation documentation doesn't mention --namespace on upgrade #1728

Closed
thoraxe opened this issue Jul 31, 2020 · 1 comment · Fixed by #1729
Closed

Helm installation documentation doesn't mention --namespace on upgrade #1728

thoraxe opened this issue Jul 31, 2020 · 1 comment · Fixed by #1729
Labels
kind/bug These are bugs. kind/documentation Documentation for Agones
Milestone
1.8.0

Comments

@thoraxe
Copy link
Contributor

thoraxe commented Jul 31, 2020

https://github.com/googleforgames/agones/blob/master/site/content/en/docs/Installation/Install%20Agones/helm.md

Says:

$ helm upgrade my-release agones/agones --reuse-values --set "gameservers.namespaces={default,xbox,ps4}"

Should say:

$ helm upgrade my-release agones/agones --reuse-values --set "gameservers.namespaces={default,xbox,ps4} --namespace agones-system"

If it wants to be consistent.
@thoraxe thoraxe added the kind/bug These are bugs. label Jul 31, 2020
@thoraxe thoraxe mentioned this issue Jul 31, 2020
Merged
@thoraxe
Copy link
Contributor Author

thoraxe commented Jul 31, 2020

/kind/documentation

@aLekSer aLekSer added kind/documentation Documentation for Agones and removed kind/bug These are bugs. labels Jul 31, 2020
@markmandel markmandel added the kind/bug These are bugs. label Jul 31, 2020
@markmandel markmandel added this to the 1.8.0 milestone Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug These are bugs. kind/documentation Documentation for Agones
Projects
None yet
Milestone
1.8.0
Development

Successfully merging a pull request may close this issue.

Helm installation docs fix for missing namespace thoraxe/agones
3 participants
@thoraxe @markmandel @aLekSer