Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: make test-gen-api-docs is failing quite often #1690

Closed
aLekSer opened this issue Jul 15, 2020 · 1 comment · Fixed by #1694
Closed

CI: make test-gen-api-docs is failing quite often #1690

aLekSer opened this issue Jul 15, 2020 · 1 comment · Fixed by #1694
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs.
Milestone

Comments

@aLekSer
Copy link
Collaborator

aLekSer commented Jul 15, 2020

What happened:
Multiple Builds were failed:
https://console.cloud.google.com/cloud-build/builds/74de68e2-12de-4ab5-b8e1-ed0c4b6f47b0;step=17?project=agones-images
in this Pull Request for instance: #1685

< <h3 id="multicluster.agones.dev/v1.GameServerAllocationPolicy">GameServerAllocationPolicy
< <h3 id="multicluster.agones.dev/v1.GameServerAllocationPolicySpec">GameServerAllocationPolicySpec
3260a3266
> <p>
5211c5217
< This field is beta-level and is enabled by default, could be disabled by the &ldquo;ContainerPortAllocation&rdquo; feature.</p>
---
> This field is alpha-level and is only honored by servers that enable the &ldquo;ContainerPortAllocation&rdquo; feature.</p>
5517,5518c5523,5524
< {{% feature expiryVersion="1.8.0" %}}
< {{% feature publishVersion="1.8.0" %}}
---
> {{% feature expiryVersion="1.7.0" %}}
> {{% feature publishVersion="1.7.0" %}}
includes/website.mk:98: recipe for target 'test-gen-api-docs' failed

What you expected to happen:
No fails on make test-gen-api-docs

How to reproduce it (as minimally and precisely as possible):
Could not reproduce as of know.

Anything else we need to know?:

Environment:

  • Agones version: master (1.8.0-dev)
  • Kubernetes version (use kubectl version): n/a
  • Cloud provider or hardware configuration: CloudBuilds
  • Install method (yaml/helm):
  • Troubleshooting guide log(s):
  • Others:
@aLekSer aLekSer added the kind/bug These are bugs. label Jul 15, 2020
@aLekSer
Copy link
Collaborator Author

aLekSer commented Jul 15, 2020

I was able to reproduce this locally on MacOS 10.14.4, Docker Desktop 2.3.0.3.

Both generated files are of the same size. So the root cause is that @ahmetb gen-crd-api-reference-docs utility could not guarantee the order of objects of the same level of nesting I suppose. Thus this should not cause the logical difference between two files.
There is no diff between two versions:

diff <(sort ./agones_crd_api_reference.html) <(sort ./agones_crd_api_reference2.html) | wc -l
0
diff ././agones_crd_api_reference.html ././agones_crd_api_reference2.html
2818

You can compare this https://gist.github.com/aLekSer/13d6333c7e821e73919c384626d7bd2b to master version https://github.com/googleforgames/agones/blob/c97864fd8815212682c546facb900b3931e35f21/site/content/en/docs/Reference/agones_crd_api_reference.html

Meld diff tool output:
Compare agones_crd_api_reference

@markmandel markmandel added this to the 1.8.0 milestone Aug 11, 2020
@markmandel markmandel added the area/tests Unit tests, e2e tests, anything to make sure things don't break label Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants