docs(audits): distinguish document.write() audit from intervention #9644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
requested review from
brendankenny and
patrickhulce
as code owners
patrickhulce
approved these changes
Sep 6, 2019
| * - Lighthouse doesn't report here on that situation, though it'll show up in `errors-in-console` | ||
| * The intercention may also not block the .write() (because the connection wasn't slow), | ||
| * but it will emit a console warning. | ||
| * - Lighthouse doesn't highlight this here or in errors-in-console. (TODO: it probably should?). |
There was a problem hiding this comment.
good call. my mistake lighthouse does report these just fine. fixed and added a demo URL so we can test it out easy.
Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
brendankenny
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this resulted from some back-n-forth with @mfriesenhahn