report(refactor): Move drop down logic into a separate class #9564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnemau
changed the title
paulirish
requested changes
Aug 16, 2019
Thank you for the review, I have completed the suggested renames/refactor, please take another look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As requested, this change refactors the reports drop down into its own class because it has grown to support the ARIA action menu pattern in #9433.
The new DropDown class is responsible for UI interactions with the action button and menu, including keydown handlers on the document to close the drop down on
ESC.The ReportUIFeatures class is still responsible for performing actions when a user activates a link in the drop down menu.
Related Issues/PRs
#9433