Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: add link to cldr parentLocales #9520

Merged
merged 2 commits into from
Aug 9, 2019
Merged

i18n: add link to cldr parentLocales #9520

merged 2 commits into from
Aug 9, 2019

Conversation

paulirish
Copy link
Member

handy link I wanted to have even handier.

@@ -10,6 +10,7 @@
*
* Google locale inheritance rules: https://goto.google.com/ccssm
* CLDR language aliases: https://www.unicode.org/cldr/charts/latest/supplemental/aliases.html
* CLDR locale inheritance: https://github.com/unicode-cldr/cldr-core/blob/master/supplemental/parentLocales.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wowza that's a lot of english ones, should we be doing something with those aliases here?

or is en-001 === en-US?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or is en-001 === en-US?

i initially was gonna say "yes", but apparently not!

first, the 419 in es-419 comes from UN M49 and in there, 001 is world and 150 is europe.

BUT en-GB is also parented by en-001. (side note: en-150 seems pretty esoteric.. i think has more to do with date/time, but i'm not sure.)

see https://www.ctrl.blog/entry/en-001.html starting at "The end of the US locale’s hegemony in CLDR" 🤣

http://cldr.unicode.org/development/development-process/design-proposals/english-inheritance helps even more because it spells out explicitly the en_XX that implicitly fall back to en which, yes, === en_US.

man this shit is fascinating.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's also a little confusing because we split inheritance between here and in i18n.lookupLocale. Maybe there's a way to make that and these manual overrides here more joined up

@brendankenny
Copy link
Member

what are we doing with this link? Some of these we get wrong (e.g. i18n.lookupLocale('pt-AO') gives 'pt' even though we have 'pt-PT'). Should we just fix them? And I'm still not sure after the above what we should do with all the en-001 and root entries :)

@exterkamp
Copy link
Member

what are we doing with this link? Some of these we get wrong (e.g. i18n.lookupLocale('pt-AO') gives 'pt' even though we have 'pt-PT'). Should we just fix them? And I'm still not sure after the above what we should do with all the en-001 and root entries :)

Should this be the first step towards better inheritance? Add in this canonical link for parent-child relationships. Then follow-up in i18n phase 2/3 to adjust our locales?

@brendankenny
Copy link
Member

Should this be the first step towards better inheritance? Add in this canonical link for parent-child relationships. Then follow-up in i18n phase 2/3 to adjust our locales?

Just trying to clarify the value of the document wrt Lighthouse :)

It's (mostly) not documentation for what we're currently doing, so it's not a great reference without a note about that for future readers. Or is it a TODO?

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM, I guess this was mostly an exercise in identifying future i18n fidelity work anyhow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants