Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: clean up crufty gather-runner tests #9227

Merged
merged 1 commit into from
Jun 18, 2019
Merged

tests: clean up crufty gather-runner tests #9227

merged 1 commit into from
Jun 18, 2019

Conversation

brendankenny
Copy link
Member

@brendankenny brendankenny commented Jun 18, 2019

noticed a bunch of places in gather-runner-test.js using old and outdated arguments. config where they aren't needed, url instead of requestedUrl, etc. Cleans those up :)

In theory most of these aren't touched by the particular code path they pass through (hence passing tests), but makes for a very confusing copy/paste experience when trying to add new tests to the file.

Didn't touch async/await or anything to keep test changes easy to review.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants